Skip to content

Conversation

@DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Jan 8, 2026

Summary: Isolated the problem to the fuse view cascade. Before I was conditionally running it in ReplaceNopTransposeOrPermuteWithViewPass only if the maybe_remove_or_replace made any modifications, but for some reason was getting numerical mismatches. Always running this pass resolves the problem.

Differential Revision: D90353766

Summary: Isolated the problem to the fuse view cascade. Before I was conditionally running it in ReplaceNopTransposeOrPermuteWithViewPass only if the maybe_remove_or_replace made any modifications, but for some reason was getting numerical mismatches. Always running this pass resolves the problem.

Differential Revision: D90353766
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16513

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1b87e88 with merge base 7815c38 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 8, 2026

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90353766.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit 41491c0 into pytorch:main Jan 9, 2026
146 of 158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants