Explicitly construct Span<EValue*> from EValue*[] in tests #16520
+117
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GCC exhibits inconsistent behavior where it applies array-to-pointer decay when calling through function pointers, but not for direct function calls, even though both should invoke the same conversion to the parameter type.
Minimal reproduction:
A similar issue is tracked at: GCC Bugzilla 114812
In ExecuTorch, OpFunction is defined as:
When tests call
(*func)(context, stack)wherestackis anEValue*[]array, GCC decays it toEValue**before considering Span's array constructortemplate<size_t N> Span(T (&)[N]), causing compilation to fail.This PR updates call sites to work around this issue by explicitly constructing the Span. An alternative option would be to convert the C arrays to std::arrays, which would not be subject to array to pointer decay.
Test plan