Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #16475 by @GregoryComer
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/167/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/orig
Differential Revision: D89902033
@diff-train-skip-merge

Pull Request resolved: #16474

Remove the EXECUTORCH_CLIENTS buck client list that gates visibility on core infrastructure
targets. This removes the gating rule in runtime_wrapper.bzl and replaces all visibility
blocks containing @EXECUTORCH_CLIENTS with explicit PUBLIC visibility.

This is part 1 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers:
- build/runtime_wrapper.bzl (removes the gating rule)
- runtime/core/* targets
- runtime/platform targets
ghstack-source-id: 332138690
@exported-using-ghexport

Differential Revision: [D89902032](https://our.internmc.facebook.com/intern/diff/D89902032/)
…ackend/executor/kernel)

Pull Request resolved: #16475

Remove the EXECUTORCH_CLIENTS buck client list visibility gating from runtime
targets outside of core. This replaces all visibility blocks containing
@EXECUTORCH_CLIENTS with explicit PUBLIC visibility.

This is part 2 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers:
- runtime/backend targets
- runtime/executor targets
- runtime/kernel targets
ghstack-source-id: 332138688
@exported-using-ghexport

Differential Revision: [D89902033](https://our.internmc.facebook.com/intern/diff/D89902033/)
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 9, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16522

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit dfac039 with merge base 09b5bdb (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2026
Base automatically changed from gh/GregoryComer/167/orig to main January 10, 2026 19:42
@GregoryComer GregoryComer merged commit 8c7630a into main Jan 10, 2026
161 of 170 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/168/orig branch January 10, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants