Skip to content

[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Devtools, Examples & More #16527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregoryComer merged 7 commits into from
Jan 10, 2026
+326 −1,256
Merged

[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Devtools, Examples & More #16527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70d0c88
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Core
GregoryComer Jan 8, 2026
dfac039
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Runtime (b…
GregoryComer Jan 8, 2026
a9e3617
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Kernels
GregoryComer Jan 8, 2026
885d27f
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - XNNPACK & …
GregoryComer Jan 8, 2026
45ab4a2
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Other Back…
GregoryComer Jan 8, 2026
a1fb8da
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Extensions
GregoryComer Jan 8, 2026
3e5cb83
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Devtools, …
GregoryComer Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backends/aoti/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def define_common_targets():
supports_python_dlopen = True,
# Constructor needed for backend registration.
compiler_flags = ["-Wno-global-constructors"],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
deps = [
"//executorch/runtime/core:core",
"//executorch/runtime/core/exec_aten:lib",
Expand All @@ -67,7 +67,7 @@ def define_common_targets():
supports_python_dlopen = True,
# Constructor needed for backend registration.
compiler_flags = ["-Wno-global-constructors"],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
deps = [
"//executorch/runtime/backend:interface",
"//executorch/runtime/core:core",
Expand All @@ -80,7 +80,7 @@ def define_common_targets():
# @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole)
link_whole = True,
supports_python_dlopen = True,
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
exported_deps = [
":common_shims",
":delegate_handle",
Expand Down
31 changes: 7 additions & 24 deletions backends/apple/coreml/TARGETS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ oncall("executorch")
# TODO: this is a placeholder to support internal fbcode build. We should add the coreml backend target properly.
runtime.python_library(
name = "coreml",
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)

runtime.python_library(
Expand All @@ -19,9 +17,7 @@ runtime.python_library(
"compiler/*.py",
"logging.py",
]),
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
"fbsource//third-party/pypi/coremltools:coremltools",
":executorchcoreml",
Expand All @@ -36,9 +32,7 @@ runtime.python_library(
"partition/*.py",
"logging.py",
]),
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
"fbsource//third-party/pypi/coremltools:coremltools",
":backend",
Expand All @@ -55,9 +49,7 @@ runtime.python_library(
srcs = glob([
"quantizer/*.py",
]),
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)

runtime.python_library(
Expand All @@ -66,10 +58,7 @@ runtime.python_library(
"recipes/__init__.py",
"recipes/coreml_recipe_provider.py"
],
visibility = [
"@EXECUTORCH_CLIENTS",
"//executorch/export/...",
],
visibility = ["PUBLIC"],
deps = [
"fbsource//third-party/pypi/coremltools:coremltools",
":coreml_recipe_types",
Expand All @@ -91,10 +80,7 @@ runtime.python_library(
srcs = [
"recipes/coreml_recipe_types.py",
],
visibility = [
"@EXECUTORCH_CLIENTS",
"//executorch/export/...",
],
visibility = ["PUBLIC"],
deps = [
"//executorch/export:recipe",
],
Expand Down Expand Up @@ -124,10 +110,7 @@ runtime.cxx_python_extension(
types = [
"executorchcoreml.pyi",
],
visibility = [
"//executorch/examples/apple/coreml/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
"fbsource//third-party/nlohmann-json:nlohmann-json",
"fbsource//third-party/pybind11:pybind11",
Expand Down
8 changes: 2 additions & 6 deletions backends/apple/mps/TARGETS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ runtime.python_library(
"__init__.py",
"mps_preprocess.py",
],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
":operators",
":serialization",
Expand Down Expand Up @@ -49,9 +47,7 @@ runtime.python_library(
srcs = glob([
"partition/*.py",
]),
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
":backend",
"//caffe2:torch",
Expand Down
11 changes: 1 addition & 10 deletions backends/apple/mps/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,7 @@ def define_common_targets(is_xplat = False, platforms = []):
"runtime/operations/*.h",
]),
"srcs": MPS_BACKEND_BUCK_SRCS,
"visibility": [
"//executorch/backends/apple/...",
"//executorch/examples/...",
"//executorch/exir/backend:backend_lib",
"//executorch/extension/pybindings/...",
"//executorch/runtime/backend/...",
"//executorch/devtools/runners/...",
"//executorch/test/...",
"@EXECUTORCH_CLIENTS",
],
"visibility": ["PUBLIC"],
"link_whole": True,
}

Expand Down
4 changes: 2 additions & 2 deletions backends/arm/runtime/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def define_common_targets():
name = "vela_bin_stream",
srcs = ["VelaBinStream.cpp"],
exported_headers = ["VelaBinStream.h"],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
deps = [
"//executorch/runtime/core:core",
],
Expand All @@ -21,7 +21,7 @@ def define_common_targets():
supports_python_dlopen = True,
# Constructor needed for backend registration.
compiler_flags = ["-Wno-global-constructors"],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
deps = [
"//executorch/runtime/backend:interface",
":vela_bin_stream",
Expand Down
5 changes: 1 addition & 4 deletions backends/cadence/fusion_g3/operators/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ def define_operator(name: str, deps: list[str] | None = None) -> None:
name = op_name,
srcs = [op_name + ".cpp"],
platforms = CXX,
visibility = [
"//executorch/backends/cadence/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
compatible_with = ["ovr_config//cpu:xtensa"],
deps = deps + common_deps,
)
Expand Down
5 changes: 1 addition & 4 deletions backends/cadence/generic/kernels/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ def define_common_targets():
exported_headers = [
"kernels.h",
],
visibility = [
"//executorch/backends/cadence/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
platforms = CXX,
)
Loading
Loading