Enable Ethos-U85 support in Vela #5002
Conversation
Switch pinned version of Vela with Ethos-U85 support. Adapt the compiler arguments and add a compile_spec to support targetting Ethos-U85. Signed-off-by: Per Åstrand <[email protected]> Signed-off-by: Tom Allsop <[email protected]> Co-authored-by: Tom Allsop <[email protected]> Change-Id: Ia2bb22c55029341c151c7040b78877502c5a4157
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5002
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 6ec5324 with merge base 3171ede ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label ciflow/trunk |
|
Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help. |
|
Please seek CI approval before scheduling CIFlow labels |
|
@pytorchbot label 'partner: arm' |
pytorch-bot
bot
added
the
partner: arm
|
@pytorchbot label ciflow/trunk |
|
Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help. |
There was a problem hiding this comment.
LGTM at a high level. Congratulations for getting Regor to this point. There has a been a lot of anticipation around this and us not able to see the progress made it suspenseful 😄.
Stamping it to indicate that the core is good. Let's please resolve comments before I merge.
backends/arm/test/ops/test_add.py
Outdated
| test_data = (operand1, operand2) | ||
| self._test_add_tosa_BI_pipeline(self.Add2(), test_data) | ||
|
|
||
| # TODO(MLETORCH-352) Remove @unittest.expectedFailure when bug fixed in Regor |
There was a problem hiding this comment.
Can these tickets be mirrored on ET GH Issues? Or just description of the bug and corresponding MLE ticket in GH Issue?
There was a problem hiding this comment.
This shouldn't be needed anymore - as some of these TODOs have been removed. I have amended one of the TODOs in lieu of a GitHub issue
| git clone https://review.mlplatform.org/ml/ethos-u/ethos-u-vela | ||
| repo_dir="${root_dir}/ethos-u-vela" | ||
| base_rev=7706c1281166e7611f4300ed26338087152a33c9 | ||
| base_rev=d362f5443f67b1e6213a9d8f124edff758efac96 |
There was a problem hiding this comment.
seems like we are regressing a bit on U55, is that a concern when we move to the new backend?
There was a problem hiding this comment.
How do you mean regressing Digant?
and Per, do you mean no we're not regressing or no we're not concerned? :)
edit:
Ok checking the run.sh behavior we're not regressing in the end example (as above we don't pass the debug-force-regor) but we regress some unit tests. I'd prefer we push ahead this way as we'll have regor improvements shortly and fix the tests and update the run.sh behaviour, rather than try and juggle unit testing the old flow
This is cleaner as our aim is to change the compilation path for U55 as well.
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Rebase please? |
Change-Id: I854f2c88f19147d10a404a8d18322efbee6e620c Signed-off-by: Tom Allsop <[email protected]>
Change-Id: I008087123b40d3913707f0009d8f8ea8e135c97c Signed-off-by: Tom Allsop <[email protected]>
|
Sorry for the delayed response to the PR @digantdesai. Let me know if you need anything else |
|
@pytorchbot label ciflow/trunk |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in bcd156b. |
6 participants
Switch pinned version of Vela with Ethos-U85 support. Adapt the compiler arguments and add a compile_spec to support targetting Ethos-U85.