Fix issue with debug TOSA dumps being overwritten #5029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a graph is partitioned into multiple partitions the Arm Backend overwrote the debug dump of TOSA intermediate files so that only the files for the last partition were available. To fix this the delegation tag is now appended to the file names. Change-Id: I283710e180b10b4aea79d88098d1f77d3e5c22f2 Signed-off-by: Benjamin Klimczak <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5029
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 11d91e3 with merge base 61ddee5 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label 'partner: arm' |
pytorch-bot
bot
added
the
partner: arm
digantdesai
approved these changes
Sep 5, 2024
| dbg_tosa_dump( | ||
| tosa_graph, | ||
| artifact_path, | ||
| suffix="{}".format(f"_{tag}" if tag else ""), |
There was a problem hiding this comment.
Suffix can be _None, FYI
|
|
||
|
|
||
| def _get_first_delegation_tag(graph_module) -> str | None: | ||
| """Get the first delegation tag from the graph_module or return None.""" |
There was a problem hiding this comment.
can you say that tag contains partition_id thus is unique
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in 7998b7f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a graph is partitioned into multiple partitions the Arm Backend overwrote the debug dump of TOSA intermediate files so that only the files for the last partition were available. To fix this the delegation tag is now appended to the file names.