Skip to content

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Sep 6, 2024

No description provided.

Copy link

pytorch-bot bot commented Sep 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5137

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 7863773 with merge base 07e15a9 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2024
@guangy10 guangy10 marked this pull request as draft September 6, 2024 18:27
@guangy10 guangy10 force-pushed the add_device_pool_for_s24 branch from 962be33 to 4ef9f4d Compare September 6, 2024 19:51
@guangy10 guangy10 changed the base branch from main to disable_fail_fast_for_benchmark_jobs September 6, 2024 19:52
Base automatically changed from disable_fail_fast_for_benchmark_jobs to main September 6, 2024 22:01
@guangy10 guangy10 force-pushed the add_device_pool_for_s24 branch from 4ef9f4d to e320442 Compare September 6, 2024 22:42
@guangy10
Copy link
Contributor Author

guangy10 commented Sep 6, 2024

Scheduled job: https://github.com/pytorch/executorch/actions/runs/10746356523.

Let's see if app can be installed and run on S24

@guangy10 guangy10 marked this pull request as ready for review September 6, 2024 23:04
@guangy10 guangy10 requested a review from huydhn September 6, 2024 23:04
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's see if the benchmark job passes

@guangy10
Copy link
Contributor Author

guangy10 commented Sep 6, 2024

LGTM! Let's see if the benchmark job passes

We should expect (stories110M, xnnpack) working on S24. That's the only thing we should look at. Other models will fail until @kirklandsign has the test-spec updated for the minibench and the minibench is built with both xnn & qnn backends.

@guangy10
Copy link
Contributor Author

guangy10 commented Sep 6, 2024

INFO:root:mobile-job-android-10746356523-1-2024-09-06-BpXToJcY FAILED 
INFO:root:  Samsung Galaxy S24 FAILED 

https://github.com/pytorch/executorch/actions/runs/10746356523/job/29807680315


09-07 09:40:40.405  2287  2810 I PackageManager: START INSTALL PACKAGE: observer{199912536}
09-07 09:40:40.405  2287  2810 I PackageManager:           stagedDir{/data/app/vmdl875418861.tmp}
09-07 09:40:40.405  2287  2810 I PackageManager:           pkg{com.example.executorchllamademo}
09-07 09:40:40.405  2287  2810 I PackageManager:           versionCode{1}
09-07 09:40:40.405  2287  2810 I PackageManager:           Request from{null}
09-07 09:40:40.747  2287  2563 D LauncherAppsService: Calling onPackageAdded: com.example.executorchllamademo, uid: 10314
09-07 09:40:40.747  2287  2563 D LauncherAppsService: Calling onPackageAdded: com.example.executorchllamademo, listener: com.airwatch.androidagent(UserHandle{0}, 20116)
09-07 09:40:40.747  2287  2563 D LauncherAppsService: Calling onPackageAdded: com.example.executorchllamademo, listener: com.sec.android.app.launcher(UserHandle{0}, 4193)
09-07 09:40:40.747  2287  2563 D LauncherAppsService: Calling onPackageAdded: com.example.executorchllamademo, listener: android(UserHandle{0}, 2287)
09-07 09:40:40.747  2287  2563 D LauncherApps: onPackageAdded 0,com.example.executorchllamademo
09-07 09:40:40.747  2287  2563 D LauncherAppsService: Calling onPackageAdded: com.example.executorchllamademo, listener: com.android.systemui(UserHandle{0}, 3597)
09-07 09:40:40.747  2287  2563 D LauncherAppsService: Calling onPackageAdded: com.example.executorchllamademo, listener: com.google.android.as(UserHandle{0}, 25495)
09-07 09:40:40.747  3597 25422 D LauncherApps: onPackageAdded 0,com.example.executorchllamademo


09-07 09:40:40.838 20116 20280 I WS1     : ClientAppRequestManagernotifyClientAppState() : appInfo is NULL for package com.example.executorchllamademo


09-07 09:40:40.970 20116 23150 I WS1_PermissionUtils: No permission policy found for the installed package com.example.executorchllamademo

09-07 09:40:41.123 23014 23021 W ziparchive: Unable to open '/data/app/~~E-Gj8Cesdx97HKwtyFMz0w==/com.example.executorchllamademo-tx9gBqU96o1DqGcDZnaFhg==/base.dm': No such file or directory
09-07 09:40:41.123 23014 23021 W ziparchive: Unable to open '/data/app/~~E-Gj8Cesdx97HKwtyFMz0w==/com.example.executorchllamademo-tx9gBqU96o1DqGcDZnaFhg==/base.dm': No such file or directory


It seems like the app is installed but some permission is not granted? @huydhn @kirklandsign

@guangy10 guangy10 force-pushed the add_device_pool_for_s24 branch from e320442 to e09a7db Compare September 13, 2024 17:48
@guangy10 guangy10 force-pushed the add_device_pool_for_s24 branch from e09a7db to 7863773 Compare September 13, 2024 17:51
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@guangy10 merged this pull request in bba4040.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants