Skip to content

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 11, 2024

This PR has 2 fixes:

  • Use Apple perf workflow to validate the iOS test spec in the same way that we are doing for Android spec
  • I also attempt to fix this concurrency deadlock when running the upload test spec workflow in trunk https://github.com/pytorch/executorch/actions/runs/10820832880. This can only be tested once the PR lands though

@huydhn huydhn requested a review from guangy10 September 11, 2024 23:56
Copy link

pytorch-bot bot commented Sep 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5293

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5144c2d with merge base a4be79f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2024
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 623b7b6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants