Skip to content

Conversation

cymbalrush
Copy link
Contributor

Fixes a couple of issues

  • Prewarms stateful model
  • The prediction was run twice if output backings was used.
  • Adds unit test for stateful model

Copy link

pytorch-bot bot commented Sep 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5294

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 835eeb5 with merge base cac2c05 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2024
@cymbalrush
Copy link
Contributor Author

@pytorchbot label ciflow/trunk

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Does stateful model also work on old OS?

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cymbalrush
Copy link
Contributor Author

Thanks for the fix! Does stateful model also work on old OS?

Unfortunately no, state ops were introduced in iOS 18.

@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in 08c8c6e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants