Enable optimized build for portable configuration of test-models #5317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5317
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5a7240d with merge base fe53d41 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Sep 12, 2024
…orch#5317) Summary: PR 5244 probably broke it, because it makes optimized ops a requirement to run llama without xnnpack. Pull Request resolved: pytorch#5317 Test Plan: `bash .ci/scripts/test_model.sh llama2 cmake portable` was broken and now succeeds Reviewed By: larryliu0820 Differential Revision: D62591634 Pulled By: swolchok
swolchok
force-pushed
the
unbreak-test-models-llama-portable
branch
from
72b03f8 to
5a7240d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62591634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: #5244 probably broke it, because it makes optimized ops a requirement to run llama without xnnpack.
Test Plan:
bash .ci/scripts/test_model.sh llama2 cmake portablewas broken and now succeeds