Mark all pybindings.portable_lib names as @experimental #5329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5329
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8bbf70a with merge base 3264a7b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62608680 |
Summary: Pull Request resolved: pytorch#5329 We plan to replace this with a new API, but it's not likely to happen for beta. Mark this as experimental to set expectations better. Differential Revision: D62608680
|
This pull request was exported from Phabricator. Differential Revision: D62608680 |
dbort
force-pushed
the
export-D62608680
branch
from
2582f65 to
8bbf70a
Compare
larryliu0820
approved these changes
Sep 13, 2024
mergennachin
approved these changes
Sep 13, 2024
|
This pull request has been merged in 1bb5b20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We plan to replace this with a new API, but it's not likely to happen for beta. Mark this as experimental to set expectations better.
We plan to replace this with a new API, but it's not likely to happen for beta. Mark this as experimental to set expectations better.
Turns out that decorating the
.pyifile doesn't actually raise any warnings, but doing so will be more clear to users who read it.Test Plan:
Differential Revision: D62608680