-
Notifications
You must be signed in to change notification settings - Fork 698
Update executorch pin to the newest nightly #5428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5428
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Unrelated FailureAs of commit 37f2352 with merge base 06c0fa3 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D62882706 |
|
This pull request was exported from Phabricator. Differential Revision: D62882706 |
Summary: Pull Request resolved: pytorch#5428 I need to clean up the deprecated method from export side, hence I need more updated version of pytorch in OSS. Reviewed By: guangy10 Differential Revision: D62882706
d778663 to
767d03c
Compare
|
@pytorchbot rebase |
|
@huydhn do you know why the HuggingFace job can't find the secret in this PR? Only in this PR. I see the same job works fine on trunk https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=test-huggingface and other PRs |
|
Oh, this one is a forked PR, so the secret actually comes from https://github.com/tugsbayasgalan/executorch-1 repo. This is a security feature to ensure that people won't be able to steal the secret via submitting pull requests, so it's what it is. @tugsbayasgalan You will need to submit a PR via a branch in https://github.com/pytorch/executorch (non-forked PR). Then the PR will have access to the secret from ET repo. Another way is that you can add your own HF token to https://github.com/tugsbayasgalan/executorch-1 with the same name. I believe we only need a read only token here. |
Summary: Pull Request resolved: pytorch#5428 I need to clean up the deprecated method from export side, hence I need more updated version of pytorch in OSS. Reviewed By: guangy10 Differential Revision: D62882706
767d03c to
37f2352
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62882706 |
…#5441) Summary: What shows here (#5428 (comment)) seems to be a common issue especially for people who are exporting the Diff to GitHub from Phabricator. Added an error message when secret is empty. Pull Request resolved: #5441 Reviewed By: kirklandsign Differential Revision: D62901954 Pulled By: guangy10 fbshipit-source-id: a5949331b8193779e685d84fd99770c9aa5bfd41
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary: I need to clean up the deprecated method from export side, hence I need more updated version of pytorch in OSS.
Differential Revision: D62882706