Skip to content

Conversation

@tugsbayasgalan
Copy link
Contributor

Summary: I need to clean up the deprecated method from export side, hence I need more updated version of pytorch in OSS.

Differential Revision: D62882706

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5428

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Unrelated Failure

As of commit 37f2352 with merge base 06c0fa3 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62882706

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62882706

tugsbayasgalan added a commit to tugsbayasgalan/executorch-1 that referenced this pull request Sep 17, 2024
Summary:
Pull Request resolved: pytorch#5428

I need to clean up the deprecated method from export side, hence I need more updated version of pytorch in OSS.

Reviewed By: guangy10

Differential Revision: D62882706
@tugsbayasgalan
Copy link
Contributor Author

@pytorchbot rebase

@guangy10
Copy link
Contributor

@huydhn do you know why the HuggingFace job can't find the secret in this PR? Only in this PR. I see the same job works fine on trunk https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=test-huggingface and other PRs

@huydhn
Copy link
Contributor

huydhn commented Sep 17, 2024

Oh, this one is a forked PR, so the secret actually comes from https://github.com/tugsbayasgalan/executorch-1 repo. This is a security feature to ensure that people won't be able to steal the secret via submitting pull requests, so it's what it is.

@tugsbayasgalan You will need to submit a PR via a branch in https://github.com/pytorch/executorch (non-forked PR). Then the PR will have access to the secret from ET repo. Another way is that you can add your own HF token to https://github.com/tugsbayasgalan/executorch-1 with the same name. I believe we only need a read only token here.

Summary:
Pull Request resolved: pytorch#5428

I need to clean up the deprecated method from export side, hence I need more updated version of pytorch in OSS.

Reviewed By: guangy10

Differential Revision: D62882706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62882706

facebook-github-bot pushed a commit that referenced this pull request Sep 18, 2024
…#5441)

Summary:
What shows here (#5428 (comment)) seems to be a common issue especially for people who are exporting the Diff to GitHub from Phabricator. Added an error message when secret is empty.

Pull Request resolved: #5441

Reviewed By: kirklandsign

Differential Revision: D62901954

Pulled By: guangy10

fbshipit-source-id: a5949331b8193779e685d84fd99770c9aa5bfd41
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants