[ET-VK][op_tests][BE] Refactor codegen components to prepare for benchmark generation #5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hmark generation ## Context Refactor operator test code generation scripts, such that components can be re-used to generate operator benchmarks. In broad strokes, the refactors implemented by this diff are as follows: * Improve granularity of Python modules * Replace `test` with `correctness_test`, to make it clear that we are generating correctness tests. **Note that I haven't changed the top level target name `compute_graph_op_tests_bin` since I believe it would be too verbose. Differential Revision: [D63286131](https://our.internmc.facebook.com/intern/diff/D63286131/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5560
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0948f95 with merge base f68a138 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63286131 |
…re for benchmark generation" ## Context Refactor operator test code generation scripts, such that components can be re-used to generate operator benchmarks. In broad strokes, the refactors implemented by this diff are as follows: * Improve granularity of Python modules * Replace `test` with `correctness_test`, to make it clear that we are generating correctness tests. **Note that I haven't changed the top level target name `compute_graph_op_tests_bin` since I believe it would be too verbose. Differential Revision: [D63286131](https://our.internmc.facebook.com/intern/diff/D63286131/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63286131 |
nathanaelsee
approved these changes
Sep 23, 2024
|
This pull request has been merged in ca0e48c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Refactor operator test code generation scripts, such that components can be re-used to generate operator benchmarks.
In broad strokes, the refactors implemented by this diff are as follows:
testwithcorrectness_test, to make it clear that we are generating correctness tests. **Note that I haven't changed the top level target namecompute_graph_op_tests_binsince I believe it would be too verbose.Differential Revision: D63286131