Add model files support for android tokenizer #5727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add model files support for android tokenizer. Previously we only support .bin files, but since the runner also supports .model now, updating the app side logic to allow .model tokenizer files. Differential Revision: D63491811
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5727
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 98e51dd with merge base 8f3a83b ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63491811 |
|
This pull request has been merged in fcdfe06. |
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: #5727 Add model files support for android tokenizer. Previously we only support .bin files, but since the runner also supports .model now, updating the app side logic to allow .model tokenizer files. Reviewed By: larryliu0820 Differential Revision: D63491811 fbshipit-source-id: b01ca836798794cbd0b0b377aa096a5c61a8f715 (cherry picked from commit fcdfe06)
Cherry picking #5727The cherry pick PR is at #5768 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Sep 30, 2024
Add model files support for android tokenizer (#5727) Summary: Pull Request resolved: #5727 Add model files support for android tokenizer. Previously we only support .bin files, but since the runner also supports .model now, updating the app side logic to allow .model tokenizer files. Reviewed By: larryliu0820 Differential Revision: D63491811 fbshipit-source-id: b01ca836798794cbd0b0b377aa096a5c61a8f715 (cherry picked from commit fcdfe06) Co-authored-by: Riandy Riandy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add model files support for android tokenizer. Previously we only support .bin files, but since the runner also supports .model now, updating the app side logic to allow .model tokenizer files.
Differential Revision: D63491811