Add OptionalIntArrayRef used by torchgen. #5735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5735
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit a778601 with merge base 98c5efa ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63568016 |
Summary: Adds OptionalIntArrayRef for generated cpp using torchgen. Generated code with torchgen.api.types.CppSignatureGroup uses additional aliases that are not currently defined in exec_aten.h. This diff adds support for OptionalIntArrayRef. Example: aten::mean.dim uses an optional int array that would end up using `OptionalIntArrayRef`. Differential Revision: D63568016
hsharma35
force-pushed
the
export-D63568016
branch
from
6d16432 to
a778601
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63568016 |
zonglinpeng
approved these changes
Oct 3, 2024
|
This pull request has been merged in 0e5b92d. |
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Summary: Pull Request resolved: #5735 Adds OptionalIntArrayRef for generated cpp using torchgen. Generated code with torchgen.api.types.CppSignatureGroup uses additional aliases that are not currently defined in exec_aten.h. This diff adds support for OptionalIntArrayRef. Example: aten::mean.dim uses an optional int array that would end up using `OptionalIntArrayRef`. Reviewed By: zonglinpeng Differential Revision: D63568016 fbshipit-source-id: fc87338632c5d2e84f1dd9b088d69ad304a13d1c (cherry picked from commit 0e5b92d)
Cherry picking #5735The cherry pick PR is at #6145 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 11, 2024
Add OptionalIntArrayRef used by torchgen. (#5735) Summary: Pull Request resolved: #5735 Adds OptionalIntArrayRef for generated cpp using torchgen. Generated code with torchgen.api.types.CppSignatureGroup uses additional aliases that are not currently defined in exec_aten.h. This diff adds support for OptionalIntArrayRef. Example: aten::mean.dim uses an optional int array that would end up using `OptionalIntArrayRef`. Reviewed By: zonglinpeng Differential Revision: D63568016 fbshipit-source-id: fc87338632c5d2e84f1dd9b088d69ad304a13d1c (cherry picked from commit 0e5b92d) Co-authored-by: Matthias Cremon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds OptionalIntArrayRef for generated cpp using torchgen.
Generated code with torchgen.api.types.CppSignatureGroup uses additional aliases that are not currently defined in exec_aten.h. This diff adds support for OptionalIntArrayRef.
Example: aten::mean.dim uses an optional int array that would end up using
OptionalIntArrayRef.Differential Revision: D63568016