Skip to content

Conversation

YifanShenSZ
Copy link
Collaborator

@YifanShenSZ YifanShenSZ commented Sep 30, 2024

Document

  • The export python script arguments to export llama for coreml
  • The cmake argument to compile Mac runner with coreml backend

Copy link

pytorch-bot bot commented Sep 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5745

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 70e9d27 with merge base 905b88c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2024
@YifanShenSZ YifanShenSZ marked this pull request as ready for review September 30, 2024 05:32
@YifanShenSZ
Copy link
Collaborator Author

@cccclai @cymbalrush

@cccclai
Copy link
Contributor

cccclai commented Sep 30, 2024

Actually do you mind seperating the doc change and the code change? doc change is easier to cherry pick while code change may take some time

@YifanShenSZ
Copy link
Collaborator Author

Sure, this PR now focuses only on doc update, to be cherry picked for beta release

Script clean up now stands alone in #5762, and don't have to be cherry picked

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in 418c4c3.

@cccclai
Copy link
Contributor

cccclai commented Sep 30, 2024

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Sep 30, 2024
Summary:
Document
* The export python script arguments to export llama for coreml
* The cmake argument to compile Mac runner with coreml backend

Minor fix: Remove outdated arguments

Pull Request resolved: #5745

Reviewed By: kirklandsign

Differential Revision: D63652220

Pulled By: cccclai

fbshipit-source-id: 1703158b4e2b31cc29d08e9262e56d564a90e539
(cherry picked from commit 418c4c3)
@pytorchbot
Copy link
Collaborator

Cherry picking #5745

The cherry pick PR is at #5774 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

jackzhxng pushed a commit that referenced this pull request Sep 30, 2024
Polish CoreML Llama Doc (#5745)

Summary:
Document
* The export python script arguments to export llama for coreml
* The cmake argument to compile Mac runner with coreml backend

Minor fix: Remove outdated arguments

Pull Request resolved: #5745

Reviewed By: kirklandsign

Differential Revision: D63652220

Pulled By: cccclai

fbshipit-source-id: 1703158b4e2b31cc29d08e9262e56d564a90e539
(cherry picked from commit 418c4c3)

Co-authored-by: yifan_shen3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants