Create pull_request_template.md #5771
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5771
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5d13a9f with merge base e93ad5f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
added
release notes: misc
.github/pull_request_template.md
Outdated
|
|
||
| [PLEASE REMOVE] If this PR closes an issue, please add a `Fixes #<issue-id>` line. | ||
|
|
||
| [PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add the following "Release notes: <area>" label. |
There was a problem hiding this comment.
If we're going to start using these labels, we need to document them so authors know how to pick one. https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests would be a good place for it, and we should point to that from here.
And if you're proposing that we do this, we'll need to educate everyone on the Edge team to start using them, and to ensure that they're set before approving PRs from external contributors. It's worth writing up a workplace post pointing to this PR (which can also include the CONTRIBUTING.md updates) and asking for feedback.
Co-authored-by: Dave Bort <[email protected]>
jackzhxng
force-pushed
the
jz/pr-template
branch
from
09aedbf to
b5b3185
Compare
jackzhxng
force-pushed
the
jz/pr-template
branch
from
9df2db0 to
4caacdd
Compare
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
CONTRIBUTING.md
Outdated
| - `Release notes: backends`: changes to any of the backend delegates. | ||
| - `Release notes: build`: changes related to the build system, including major dependency upgrades, notable build flags, optimizations, etc. | ||
| - `Release notes: SDK`: changes to any of ExecuTorch's SDKs, for example the debugger & profiler. | ||
| - `Release notes: examples`: changes to any of our example LLMs integrations, such as Llama3 and Llava. |
There was a problem hiding this comment.
We have a bunch of examples that aren't LLM-focused
| - `Release notes: examples`: changes to any of our example LLMs integrations, such as Llama3 and Llava. | |
| - `Release notes: examples`: changes to any code under `examples/`. |
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary
Adds a default pull request template. Follows how PyTorch tracks changelogs for release notes, which is adding "Release notes: " labels, e.g. this PyTorch PR.
PyTorch also has a bot to remind people to add Release Notes tags, which we can try to integrate later:
Fixes #5793
Test plan
Mock pull request to check if the summary and test plan are formatted into phabricator correctly: #5790 -> D63709392.