Fix load time. #5781
Closed
Fix load time. #5781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Once loaded Module does nothing next time, we need to recreate the Module again to truly load the method again. Differential Revision: D63678792
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5781
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 7f35713 with merge base 8079eb7 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63678792 |
Contributor
|
This pull request has been merged in 04669a1. |
|
Thank you so much Anthony! With this updated test code I can run the Benchmark app for Llama model on my iPhone16 pro and get the correct model forwarding and loading time! |
Contributor
Author
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Summary: Pull Request resolved: #5781 Once loaded Module does nothing next time, we need to recreate the Module again to truly load the method again. Reviewed By: cccclai Differential Revision: D63678792 fbshipit-source-id: 1e8d6a379215e20620b73c05ce7f734e1d0fc5ce (cherry picked from commit 04669a1)
Collaborator
Cherry picking #5781The cherry pick PR is at #5889 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 4, 2024
Fix load time. (#5781) Summary: Pull Request resolved: #5781 Once loaded Module does nothing next time, we need to recreate the Module again to truly load the method again. Reviewed By: cccclai Differential Revision: D63678792 fbshipit-source-id: 1e8d6a379215e20620b73c05ce7f734e1d0fc5ce (cherry picked from commit 04669a1) Co-authored-by: Anthony Shoumikhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Once loaded Module does nothing next time, we need to recreate the Module again to truly load the method again.
Differential Revision: D63678792