Skip to content

Conversation

@robell
Copy link
Collaborator

@robell robell commented Oct 2, 2024

Add parameters for Corstone-320 to run.sh and so ability to run on Ethos-U85 target.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5818

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3ac1dc6 with merge base 152e22d (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2024
@robell robell marked this pull request as draft October 2, 2024 16:46
elif [[ ${target} == *"ethos-u85"* ]]; then
${fvp_model} \
-C mps4_board.subsystem.cpu0.CFGITCMSZ=11 \
-C mps4_board.subsystem.ethosu.num_macs=128 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be aligned with the compile spec used AoT right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's aligned with the default spec used for now e.g. ethos-u85-128 we will probably add a change to use
-C mps4_board.subsystem.ethosu.num_macs=${num_macs}
soon for U85 also to make it more generic but we should probably test it some more before.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to num_macs to match the Ethos-U55 pattern.

We need to do a followup to CI the non-default target, but as it adds a lot of cycles to the testing, we should revise the e2e flow to not run the heavyweight models on most configs.

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Oct 2, 2024
@robell robell marked this pull request as ready for review October 2, 2024 18:58
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mergennachin merged this pull request in 92d1d1e.

@robell robell deleted the model_review branch May 6, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants