[ExecuTorch] Disable animation in hot path of iOS example again #5821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D62675017 put the animations back after D62308551 removed them, presumably due to a bad rebase. Differential Revision: [D63774734](https://our.internmc.facebook.com/intern/diff/D63774734/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5821
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 08e0eb9 with merge base 8ddb846 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63774734 |
swolchok
added a commit
that referenced
this pull request
Oct 2, 2024
D62675017 put the animations back after D62308551 removed them, presumably due to a bad rebase. Differential Revision: [D63774734](https://our.internmc.facebook.com/intern/diff/D63774734/) ghstack-source-id: 245945487 Pull Request resolved: #5821
kirklandsign
approved these changes
Oct 2, 2024
Contributor
|
This pull request has been merged in 9dcd71f. |
Contributor
|
@pytorchbot cherry-pick --onto release/0.4 -c regression |
Collaborator
Cherry picking #5821The cherry pick PR is at #6118 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
This was referenced Oct 10, 2024
jackzhxng
pushed a commit
that referenced
this pull request
Oct 10, 2024
Disable animation in hot path of iOS example again (#5821) Summary: Pull Request resolved: #5821 D62675017 put the animations back after D62308551 removed them, presumably due to a bad rebase. Reviewed By: kirklandsign Differential Revision: D63774734 fbshipit-source-id: d3b6199346ca44ccc08ab5062f099314ce4298f5 (cherry picked from commit 9dcd71f) Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
D62675017 put the animations back after D62308551 removed them, presumably due to a bad rebase.
Differential Revision: D63774734