Skip to content

Conversation

@benkli01
Copy link
Collaborator

@benkli01 benkli01 commented Oct 8, 2024

In process_call_function() we need to check for output quantization explicitly when adding a tensor for the output of the current node.

In process_call_function() we need to check for output quantization
explicitly when adding a tensor for the output of the current node.

Signed-off-by: Benjamin Klimczak <[email protected]>
Change-Id: I1619431b223bfeeaaadb0fcccbe477c2c14134d0
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5977

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 4cfcae5 with merge base cb12061 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@benkli01 benkli01 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 8, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@digantdesai
Copy link
Contributor

digantdesai commented Oct 8, 2024

CI is red, assuming this is a WIP?

@benkli01 benkli01 marked this pull request as draft October 8, 2024 22:38
@benkli01
Copy link
Collaborator Author

benkli01 commented Oct 8, 2024

CI is red, assuming this is a WIP?

Yes, sorry. I meant to mark this as draft.

@benkli01
Copy link
Collaborator Author

Closing as this is covered by #6690.

@benkli01 benkli01 closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants