Skip to content

Conversation

@robell
Copy link
Collaborator

@robell robell commented Oct 9, 2024

We were in transition between an older and newer compiler version when the release branch was taken.
This is a small set of fixes to get run.sh outputting correctly.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6043

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit ffbaf9d with merge base eecf74f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
@robell robell requested a review from digantdesai October 9, 2024 13:50
@robell robell mentioned this pull request Oct 9, 2024
@digantdesai
Copy link
Contributor

We can pull in once the CI is green. Thanks @robell for a quick turn around.

@jackzhxng jackzhxng merged commit 8b012a0 into pytorch:release/0.4 Oct 9, 2024
99 of 101 checks passed
jackzhxng added a commit that referenced this pull request Oct 9, 2024
@jackzhxng
Copy link
Contributor

Reverting, missed the two failed tests

jackzhxng added a commit that referenced this pull request Oct 9, 2024
Revert "Arm run.sh fixes (#6043)"

This reverts commit 8b012a0.
@digantdesai
Copy link
Contributor

@robell can we take another stab at this? Thanks

robell added a commit to robell/executorch that referenced this pull request Oct 9, 2024
Fixes for vela compiler version, codegen flags and non-semihosted error behaviour
jackzhxng pushed a commit that referenced this pull request Oct 9, 2024
* Arm run.sh fixes (#6043)

Fixes for vela compiler version, codegen flags and non-semihosted error behaviour

* enable passing tests and remove broken split test.

Signed-off-by: Rob Elliott <[email protected]>

---------

Signed-off-by: Rob Elliott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants