Fix reporting backends and dtyep to benchmark results #6073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Couple minor fixes for reporting the benchmarking results: - qnn models are not reporting "backend" and "dtype" info in the benchmark_results.json (Android) - tinyllama mdoel is not reporting "backend" and "dtype" info in the benchmark_results.json (Android) - include compute precision to the exported coreml model name - rename "llama2" to "tinyllama" to eliminate confusion (many people thought it was llama2-7b) Pull Request resolved: #6023 Reviewed By: huydhn Differential Revision: D64074262 Pulled By: guangy10 fbshipit-source-id: c6c53d004c4fb3ad410a792639af2c22a6978b67 (cherry picked from commit 012cba9)
This was referenced Oct 9, 2024
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6073
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1395020 with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jackzhxng
approved these changes
Oct 10, 2024
Contributor
jackzhxng
left a comment
jackzhxng
left a comment
There was a problem hiding this comment.
Test scripts + qnn changes should be safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple minor fixes for reporting the benchmarking results: