op_clamp: add downcasting tests & fix #6131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6131
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit df1a5fb with merge base eecf74f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
reviewed
Oct 10, 2024
Contributor
jackzhxng
left a comment
jackzhxng
left a comment
There was a problem hiding this comment.
@manuelcandales looks good but failing tests
jackzhxng
approved these changes
Oct 11, 2024
Contributor
jackzhxng
left a comment
jackzhxng
left a comment
There was a problem hiding this comment.
Approving, noting that pull / unittest-arm (buck2) / linux-job seem to be a ci infra issue as it is occurring around the same time in both main and release/0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed By: swolchok
Differential Revision: D63716405