Skip to content

Adding executorch_prim::mod.Scalar #6133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Adding executorch_prim::mod.Scalar #6133

merged 1 commit into from
Oct 11, 2024

Conversation

@pytorchbot
Copy link
Collaborator

@pytorchbot pytorchbot commented Oct 10, 2024

Summary: Adding mod.Scalar required by the Seamless ASR model example.

Differential Revision: D63518182

@tarun292 @pytorchbot
Adding executorch_prim::mod.Scalar (#5721)
51123fb 
Summary:
Pull Request resolved: #5721

Adding mod.Scalar required by the Seamless ASR model example.

Reviewed By: JacobSzwejbka

Differential Revision: D63518182

fbshipit-source-id: b76ef5270d75a257216cdb6a218006156a2c48ce
(cherry picked from commit a4ee59a)
This was referenced Oct 10, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6133

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 51123fb with merge base eecf74f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2024
jackzhxng
jackzhxng reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarun292 looks good but broke a test (can ignore the pull / unittest-arm (buck2) / linux-job for now)

jackzhxng
jackzhxng approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure was from different issue and is being fixed, approving

@jackzhxng jackzhxng merged commit b077801 into release/0.4 Oct 11, 2024
27 of 28 checks passed
@jackzhxng jackzhxng deleted the cherry-pick-5721-by-pytorch_bot_bot_ branch October 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxng jackzhxng jackzhxng approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pytorchbot @jackzhxng @facebook-github-bot @tarun292