Skip to content

Conversation

pytorchbot
Copy link
Collaborator

It appears that upstream updates to branch tosa_reference_model/v0.8 which we used to track broke ET CI. Hard coding it to a known good version for now.

Summary:
It appears that upstream updates to branch tosa_reference_model/v0.8 which we used to track broke ET CI. Hard coding it to a known good version for now.

* Failed CI job - https://github.com/pytorch/executorch/actions/runs/11283289096/job/31382443033#step:12:26700

* Upstream branch updates - https://review.mlplatform.org/q/project:tosa%252Freference_model+branch:v0.80 Potentially culprit gerrit ids - 12676, 12677, 12678 updated today

Pull Request resolved: #6156

Reviewed By: larryliu0820

Differential Revision: D64222142

Pulled By: digantdesai

fbshipit-source-id: 8438770851f8309020755992036f8e4c50857301
(cherry picked from commit 5696b35)
Copy link

pytorch-bot bot commented Oct 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6162

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 46c6826 with merge base eecf74f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2024
@digantdesai
Copy link
Contributor

digantdesai commented Oct 11, 2024

@per assert os.path.exists( "test_collate_tosa_tests/tosa-bi/TestCollateTosaTests/test_collate_tosa_BI_tests" ) is failing, do you know what's going on here?

@digantdesai digantdesai requested review from per and robell October 11, 2024 14:10
@per
Copy link
Collaborator

per commented Oct 11, 2024

@per assert os.path.exists( "test_collate_tosa_tests/tosa-bi/TestCollateTosaTests/test_collate_tosa_BI_tests" ) is failing, do you know what's going on here?

Looks like the test-case is imported but not the code in 'backends/arm/test/common.py' : https://github.com/pytorch/executorch/pull/5028/files#diff-7bdd98f44e08ece4bb1600fa9f4ec705cfde09ce70eab92b7b89536e28b9ce08

The PR that introduced the test haven't been fully merged? https://github.com/pytorch/executorch/pull/5028/files

The commit 96bac82 seems to have gone wrong?

@mergennachin
Copy link
Contributor

@per @robell

We cut the branch on 9/14

Unless it is not specifically request for cherry-pick, it won't be picked up by the release branch.

Here are all the cherry-picks so far: #5366

You can also see the status of main vs release branches via:

There were many Arm changes since 9/14. We definitely won't be cherry-picking all of them.

In this particular case, we'd like to see if there's absolute critical things to cherry-pick to make sure the tests are green.

The Arm test failure is the last blocker before we can release the final RC.

@jackzhxng
Copy link
Contributor

Let's merge this CP in, since it fixes the TOSA reference model and follow it up by CPing in #5028, which should fix the problem. Otherwise we can also revert the non doc-related changes from #6080, since it was only CPd in for the doc fix.

@jackzhxng jackzhxng merged commit c169d91 into release/0.4 Oct 11, 2024
38 of 39 checks passed
@jackzhxng jackzhxng deleted the cherry-pick-6156-by-pytorch_bot_bot_ branch October 11, 2024 18:08
@jackzhxng
Copy link
Contributor

#6174

@mergennachin
Copy link
Contributor

mergennachin commented Oct 11, 2024

Yeah I think we shouldn't have CP'ed #5629 so late in the process.

I wasn't aware that was merged.

@jackzhxng
Copy link
Contributor

Yeah should have separated out the doc update. Thought the tests would be fine but the auto merge butchered it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants