-
Notifications
You must be signed in to change notification settings - Fork 688
[Arm] Fix tosa-reference model upstream tracking #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: It appears that upstream updates to branch tosa_reference_model/v0.8 which we used to track broke ET CI. Hard coding it to a known good version for now. * Failed CI job - https://github.com/pytorch/executorch/actions/runs/11283289096/job/31382443033#step:12:26700 * Upstream branch updates - https://review.mlplatform.org/q/project:tosa%252Freference_model+branch:v0.80 Potentially culprit gerrit ids - 12676, 12677, 12678 updated today Pull Request resolved: #6156 Reviewed By: larryliu0820 Differential Revision: D64222142 Pulled By: digantdesai fbshipit-source-id: 8438770851f8309020755992036f8e4c50857301 (cherry picked from commit 5696b35)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6162
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 46c6826 with merge base eecf74f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@per |
Looks like the test-case is imported but not the code in 'backends/arm/test/common.py' : https://github.com/pytorch/executorch/pull/5028/files#diff-7bdd98f44e08ece4bb1600fa9f4ec705cfde09ce70eab92b7b89536e28b9ce08 The PR that introduced the test haven't been fully merged? https://github.com/pytorch/executorch/pull/5028/files The commit 96bac82 seems to have gone wrong? |
We cut the branch on 9/14 Unless it is not specifically request for cherry-pick, it won't be picked up by the release branch. Here are all the cherry-picks so far: #5366 You can also see the status of main vs release branches via:
There were many Arm changes since 9/14. We definitely won't be cherry-picking all of them. In this particular case, we'd like to see if there's absolute critical things to cherry-pick to make sure the tests are green. The Arm test failure is the last blocker before we can release the final RC. |
Yeah I think we shouldn't have CP'ed #5629 so late in the process. I wasn't aware that was merged. |
Yeah should have separated out the doc update. Thought the tests would be fine but the auto merge butchered it |
It appears that upstream updates to branch tosa_reference_model/v0.8 which we used to track broke ET CI. Hard coding it to a known good version for now.
Failed CI job - https://github.com/pytorch/executorch/actions/runs/11283289096/job/31382443033#step:12:26700
Upstream branch updates - https://review.mlplatform.org/q/project:tosa%252Freference_model+branch:v0.80 Potentially culprit gerrit ids - 12676, 12677, 12678 updated today