Add max_pool2d op to Arm backend

[AdrianLundell]

• Adds node visitor and unittests
• Adds remove_getitem_op pass to convert (maxpool_get inidices + getitem) -> maxpool2d op

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6285

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 059fc82 with merge base 03b1ef2 ():

NEW FAILURES - The following jobs have failed:

• trunk / test-demo-backend-delegation (buck2) / linux-job (gh)
  RuntimeError: Command docker exec -t 2b0b828c480d4160eb41bea1294475db4d8decd34ee7b5c396d02d3f6c07b4ff /exec failed with exit code 139
• trunk / test-demo-backend-delegation (cmake) / linux-job (gh)
  RuntimeError: Command docker exec -t f154cc8eaf851d64d96c0beff054fe1b6ee53fc5d1b039b8c0f1f3a198d442eb /exec failed with exit code 139

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @AdrianLundell!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[pytorch-bot]

Please seek CI approval before scheduling CIFlow labels

[digantdesai]

@AdrianLundell please sign the CLA, can't merge until then

[digantdesai]

Rebase?

[digantdesai]

If its in WIP, make it a Draft?

[digantdesai]

@AdrianLundell - updated your permissions so hopefully the GH CI should rerun automatically when you push next time.

[zingo]

This is not WIP :)

[AdrianLundell]

Same tests are currently failing on main as well

[digantdesai]

@AdrianLundell did you get an invite to join ExecuTorch repo? If you accept and join, you can run the CI and also merge the PRs :)

[facebook-github-bot]

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[AdrianLundell]

Unrelated failures:
-Segmentation fault (core dumped) ./${CMAKE_OUTPUT_DIR}/executor_runner --model_path "./composite_model.pte" Error: Process completed with exit code 1: https://github.com/pytorch/executorch/actions/runs/11704081247/job/32595766387?pr=6285#step:12:7155

-RuntimeError: Command docker exec -t 2b0b828c480d4160eb41bea1294475db4d8decd34ee7b5c396d02d3f6c07b4ff /exec failed with exit code 139 Error: Process completed with exit code 1: https://github.com/pytorch/executorch/actions/runs/11704081247/job/32595765663?pr=6285#step:12:6701

Unclear if related:
-This Pull Request has changes that have not been imported to the Diff, please import the Pull Request: https://github.com/pytorch/executorch/pull/6285/checks?check_run_id=32595759126

[facebook-github-bot]

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.