Skip to content

Conversation

@zonglinpeng
Copy link
Contributor

Summary:

  • only migrated quant-per-tensor in this diff. will do the rest of 3 in the stack
  • solved the --start-lib --end-lib option not recognized in here - need to import libs from //executorch. Nothing do with the cxx wrapper in buck
  • aligned namespace to cadence::impl:HIFI::native
  • kernel to be removed after all ops are migrated

Differential Revision: D64194227

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6293

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ac5ec34 with merge base 8f6c16e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Oct 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64194227

zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Oct 16, 2024
Summary:

- only migrated quant-per-tensor in this diff. will do the rest of 3 in the stack
- solved the --start-lib --end-lib option not recognized in here - need to import libs from //executorch. Nothing do with the cxx wrapper in buck
- aligned namespace to cadence::impl:HIFI::native
- kernel to be removed after all ops are migrated

Reviewed By: skrtskrtfb

Differential Revision: D64194227
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64194227

Summary:

- only migrated **quant-per-tensor** in this diff. will do the rest of 3 in the stack
- solved the --start-lib --end-lib option not recognized in here - need to import libs from //executorch. Nothing do with the cxx wrapper in buck
- aligned namespace to **cadence::impl:HIFI::native and cadence::impl:HIFI::kernel**
- kernel to be removed after all ops are migrated

Reviewed By: skrtskrtfb

Differential Revision: D64194227
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64194227

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b1c94ab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants