Rename executorch-llama.aar to executorch.aar #6313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's use a uniform name. It's easier to maintain and less error prone. It won't cause BC issue. All renaming are happening within this repo, this version. For user apps, after they download or build the AAR, they can rename in their build.gradle.kts. Test: 1. `sh examples/demo-apps/android/LlamaDemo/download_prebuilt_lib.sh` run twice! 2. `sh build/build_android_llm_demo.sh` 3. `sh examples/demo-apps/android/LlamaDemo/setup.sh` 4. `sh examples/demo-apps/android/LlamaDemo/setup-with-qnn.sh`
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6313
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cmodi-meta
approved these changes
Oct 16, 2024
Riandy
approved these changes
Oct 16, 2024
Contributor
|
@kirklandsign merged this pull request in 2be0105. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use a uniform name. It's easier to maintain and less error prone.
It won't cause BC issue. All renaming are happening within this repo, this version. For user apps, after they download or build the AAR, they can rename in their build.gradle.kts.
Test:
sh examples/demo-apps/android/LlamaDemo/download_prebuilt_lib.shrun twice!sh build/build_android_llm_demo.shsh examples/demo-apps/android/LlamaDemo/setup.shsh examples/demo-apps/android/LlamaDemo/setup-with-qnn.sh