Reduced int precision for texture coordinates in q_linear op, to reduce shader register pressure. #6354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6354
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f28125c with merge base 89ba47a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64191093 |
nathanaelsee
approved these changes
Oct 18, 2024
trivedivivek
force-pushed
the
export-D64191093
branch
from
38fc72d to
e04bcc5
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 21, 2024
…ce shader register pressure. (pytorch#6354) Summary: This diff reduces precision ints for texture coordinates in the q_linear op's texture based multiplication implementation. **Context:** Texture size in a single dimension even on most high ends GPUs are limited to 65535, thus ushort is sufficient for storing texture coordinates. Reviewed By: nathanaelsee, SS-JIA Differential Revision: D64191093
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64191093 |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 21, 2024
…ce shader register pressure. (pytorch#6354) Summary: This diff reduces precision ints for texture coordinates in the q_linear op's texture based multiplication implementation. **Context:** Texture size in a single dimension even on most high ends GPUs are limited to 65535, thus ushort is sufficient for storing texture coordinates. Reviewed By: nathanaelsee, SS-JIA Differential Revision: D64191093
…ce shader register pressure. (pytorch#6354) Summary: This diff reduces precision ints for texture coordinates in the q_linear op's texture based multiplication implementation. **Context:** Texture size in a single dimension even on most high ends GPUs are limited to 65535, thus ushort is sufficient for storing texture coordinates. Reviewed By: nathanaelsee, SS-JIA Differential Revision: D64191093
trivedivivek
force-pushed
the
export-D64191093
branch
from
e04bcc5 to
f28125c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64191093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff reduces precision ints for texture coordinates in the q_linear op's texture based multiplication implementation.
Context:
Texture size in a single dimension even on most high ends GPUs are limited to 65535, thus ushort is sufficient for storing texture coordinates.
Reviewed By: SS-JIA
Differential Revision: D64191093