executorch/examples/portable/custom_ops/custom_ops_2_out.cpp: fix llvm-17-exposed format mismatches #6368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6368
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b787f2f with merge base c7a3c3f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64656845 |
meyering
pushed a commit
to meyering/executorch
that referenced
this pull request
Oct 20, 2024
…m-17-exposed format mismatches (pytorch#6368) Summary: This avoids the following errors: executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat] executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat] Differential Revision: D64656845
meyering
force-pushed
the
export-D64656845
branch
from
915827f to
d9462c3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64656845 |
meyering
pushed a commit
to meyering/executorch
that referenced
this pull request
Oct 20, 2024
…m-17-exposed format mismatches (pytorch#6368) Summary: This avoids the following errors: executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat] executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat] Also, change the format to %d and the cast to match -- perhaps a little more future-safe. Differential Revision: D64656845
meyering
force-pushed
the
export-D64656845
branch
from
d9462c3 to
c0b539b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64656845 |
meyering
pushed a commit
to meyering/executorch
that referenced
this pull request
Oct 21, 2024
…m-17-exposed format mismatches (pytorch#6368) Summary: This avoids the following errors: executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat] executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat] Also, change the format to %d and the cast to match -- perhaps a little more future-safe. Differential Revision: D64656845
meyering
force-pushed
the
export-D64656845
branch
from
c0b539b to
2fedd71
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64656845 |
…m-17-exposed format mismatches (pytorch#6368) Summary: This avoids the following errors: executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat] executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat] Also, change the format to %d and the cast to match -- perhaps a little more future-safe. Differential Revision: D64656845
meyering
force-pushed
the
export-D64656845
branch
from
2fedd71 to
b787f2f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64656845 |
tarun292
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This avoids the following errors:
executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:23:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]
executorch/examples/portable/custom_ops/custom_ops_2_out.cpp:27:7: error: format specifies type 'char' but the argument has type 'ScalarType' [-Werror,-Wformat]
Differential Revision: D64656845