Add Android standalone log target #6590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6590
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 44529ae with merge base 8f82198 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65268257 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Oct 31, 2024
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings. Differential Revision: D65268257
GregoryComer
force-pushed
the
export-D65268257
branch
from
2b15fe5 to
8001f63
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65268257 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings. Reviewed By: kirklandsign Differential Revision: D65268257
GregoryComer
force-pushed
the
export-D65268257
branch
from
8001f63 to
9c3ac51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65268257 |
kirklandsign
approved these changes
Nov 6, 2024
|
linter and CI failure |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings. Reviewed By: kirklandsign Differential Revision: D65268257
GregoryComer
force-pushed
the
export-D65268257
branch
from
9c3ac51 to
ac27907
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings. Reviewed By: kirklandsign Differential Revision: D65268257
GregoryComer
force-pushed
the
export-D65268257
branch
from
ac27907 to
92a07e5
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings. Reviewed By: kirklandsign Differential Revision: D65268257
GregoryComer
force-pushed
the
export-D65268257
branch
from
92a07e5 to
9ab749d
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings. Reviewed By: kirklandsign Differential Revision: D65268257
GregoryComer
force-pushed
the
export-D65268257
branch
from
9ab749d to
6d3f033
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 7, 2024
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings. Reviewed By: kirklandsign Differential Revision: D65268257
GregoryComer
force-pushed
the
export-D65268257
branch
from
6d3f033 to
2e0413a
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings. Test Plan: Confirmed that ET logcat logging is present in the Android ET demo app by building and running from Android Studio. Reviewed By: kirklandsign Differential Revision: D65268257 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65268257
branch
from
2e0413a to
44529ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65268257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add a standalone Android log target to enable ExecuTorch logging to logcat when not using JNI bindings.
Differential Revision: D65268257