Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kernels/aten/cpu/util/targets.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ def define_common_targets():
exported_headers = [
"copy_ops_util.h",
],
compiler_flags = ["-Wno-missing-prototypes"],
compiler_flags = select({
"DEFAULT": ["-Wno-missing-prototypes"],
"ovr_config//os:windows": [],
}),
deps = [
"//executorch/runtime/kernel:kernel_includes_aten",
"//executorch/runtime/core/exec_aten/util:tensor_util_aten",
Expand Down
5 changes: 4 additions & 1 deletion kernels/prim_ops/targets.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ def define_common_targets():
# @lint-ignore BUCKLINT link_whole, need this to register prim ops.
link_whole = True,
# prim ops are registered through a global table so the ctor needs to be allowed
compiler_flags = ["-Wno-global-constructors"],
compiler_flags = select({
"DEFAULT": ["-Wno-global-constructors"],
"ovr_config//os:windows": [],
}),
deps = [
":et_copy_index" + aten_suffix,
":et_view" + aten_suffix,
Expand Down
5 changes: 4 additions & 1 deletion shim/xplat/executorch/codegen/codegen.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,10 @@ def executorch_generated_lib(
link_whole = True,
visibility = visibility,
# Operator Registration is done through static tables
compiler_flags = ["-Wno-global-constructors"] + compiler_flags,
compiler_flags = select({
"DEFAULT": ["-Wno-global-constructors"],
"ovr_config//os:windows": [],
}) + compiler_flags,
deps = [
"//executorch/runtime/kernel:operator_registry",
"//executorch/kernels/prim_ops:prim_ops_registry" + aten_suffix,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ def define_op_library(name, deps, android_deps, aten_target, _allow_third_party_
fbandroid_platform_deps = android_deps,
# kernels often have helpers with no prototypes just disabling the warning here as the headers
# are codegend and linked in later
compiler_flags = ["-Wno-missing-prototypes"] + (
compiler_flags = select({
"DEFAULT": ["-Wno-missing-prototypes"],
"ovr_config//os:windows": [],
}) + (
# For shared library build, we don't want to expose symbols of
# kernel implementation (ex torch::executor::native::tanh_out)
# to library users. They should use kernels through registry only.
Expand Down
Loading