Remove assert for ArgSchema #6638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6638
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 4087d1c with merge base f96be5b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65316894 |
dulinriley
force-pushed
the
export-D65316894
branch
from
7d22ba0 to
00ae1e4
Compare
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Nov 12, 2024
Summary: In python 3.12, there were a few changes to runtime_checkable: https://docs.python.org/3/whatsnew/3.12.html#typing > The members of a runtime-checkable protocol are now considered “frozen” at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol I'm not sure what was monkey-patched here, but EdgeDialectOverloadPacket no longer passes the assert. I'm not sure how to fix this for real, but I just deleted it under the assumption it's not helpful enough to be worth breaking tests. Differential Revision: D65316894
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65316894 |
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Nov 12, 2024
Summary: In python 3.12, there were a few changes to runtime_checkable: https://docs.python.org/3/whatsnew/3.12.html#typing > The members of a runtime-checkable protocol are now considered “frozen” at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol I'm not sure what was monkey-patched here, but EdgeDialectOverloadPacket no longer passes the assert. I'm not sure how to fix this for real, but I just deleted it under the assumption it's not helpful enough to be worth breaking tests. Differential Revision: D65316894
dulinriley
force-pushed
the
export-D65316894
branch
from
00ae1e4 to
76ef3cb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65316894 |
Summary: In python 3.12, there were a few changes to runtime_checkable: https://docs.python.org/3/whatsnew/3.12.html#typing > The members of a runtime-checkable protocol are now considered “frozen” at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol I'm not sure what was monkey-patched here, but EdgeDialectOverloadPacket no longer passes the assert. I'm not sure how to fix this for real, but I just deleted it under the assumption it's not helpful enough to be worth breaking tests. Differential Revision: D65316894
dulinriley
force-pushed
the
export-D65316894
branch
from
76ef3cb to
4087d1c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65316894 |
JacobSzwejbka
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In python 3.12, there were a few changes to runtime_checkable:
https://docs.python.org/3/whatsnew/3.12.html#typing
I'm not sure what was monkey-patched here, but EdgeDialectOverloadPacket
no longer passes the assert.
I'm not sure how to fix this for real, but I just deleted it under the assumption
it's not helpful enough to be worth breaking tests.
Differential Revision: D65316894