Skip to content

[Java][Android] add unit test for EValue #6641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2024
Merged

[Java][Android] add unit test for EValue #6641

merged 3 commits into from
Nov 4, 2024

Conversation

@davidlin54
Copy link
Contributor

@davidlin54 davidlin54 commented Nov 4, 2024 •
edited
Loading

Add JUnit tests for EValue.

Test using:

$ cd extension/android
$ ./gradlew test

@davidlin54
Update
317e571 
[ghstack-poisoned]
@davidlin54
Update
6f8a73d 
[ghstack-poisoned]
@davidlin54
Copy link
Contributor Author

davidlin54 commented Nov 4, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6641

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e055574 with merge base 97a4600 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@davidlin54 davidlin54 mentioned this pull request Nov 4, 2024
Merged
davidlin54 added a commit that referenced this pull request Nov 4, 2024
@davidlin54
add unit test for EValue
5629358 
ghstack-source-id: b0a283d
ghstack-comment-id: 2455711092
Pull Request resolved: #6641
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2024
@davidlin54 davidlin54 changed the title add unit test for EValue [Java][Android] add unit test for EValue Nov 4, 2024
@davidlin54
Update
e055574 
[ghstack-poisoned]
davidlin54 added a commit that referenced this pull request Nov 4, 2024
@davidlin54
add unit test for EValue
296fa26 
ghstack-source-id: bab3a70
ghstack-comment-id: 2455711092
Pull Request resolved: #6641
Base automatically changed from gh/davidlin54/1/head to main November 4, 2024 21:51
@davidlin54 davidlin54 merged commit 8ab3385 into main Nov 4, 2024
38 checks passed
@davidlin54 davidlin54 deleted the gh/davidlin54/2/head branch November 4, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidlin54 @kirklandsign @facebook-github-bot