[data loader] move logic for FD data loader out of file_data_loader #6682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6682
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e645c88 with merge base f7e26d7 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@davidlin54 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
davidlin54
force-pushed
the
lind/move-fd-loader
branch
from
d298a5e to
e645c88
Compare
Contributor
|
@davidlin54 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lucylq
approved these changes
Nov 6, 2024
Contributor
lucylq
left a comment
lucylq
left a comment
There was a problem hiding this comment.
thanks for placing the logic into a new data loader and fixing size test
kirklandsign
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert changes in #6611, and move logic to new data loader to: