Use lambda on all kernel prim ops #6709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes executorch_prim::et_copy_index.tensor and executorch_prim::et_view.default also use a lamba function like the rest. This fixes a problem where the functions pointers didn't get proper values for this two ops. Signed-off-by: Zingo Andersen <[email protected]> Change-Id: Icc2623c5fe730483ddb21f041fe52de03f63a953
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6709
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit eaf42b9 with merge base dc41596 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
partner: arm
Collaborator
|
@digantdesai since this is touching code outside arm delegate, will you have a look? |
digantdesai
approved these changes
Nov 12, 2024
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes executorch_prim::et_copy_index.tensor and executorch_prim::et_view.default also use a lamba function like the rest. This fixes a problem where the functions pointers didn't get proper values for this two ops.
Tested with a non delegated view op on Arm backend.