Arm backend: execute_runner link in portable_kernels #6710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving linking of libexecutorch.a to after "-Wl,--whole-archive" This adds executorch_prim::* to the build as the executorch_prim ops are added with a c++ static initialize that get optimized away by the linker as the variable in never used in the normal linking. See docs/source/runtime-build-and-cross-compilation.md Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I914ce4dc86b5ec067461dedf7d8768c4be91bf95
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6710
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 4cd4213 with merge base abc8a5f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
partner: arm
Collaborator
Author
|
Closing this, have a better way to do this that only bring in the view and not all ops |
zingo
deleted the
Arm-backend-execute_runner-link-in-portable_kernels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving linking of libexecutorch.a to after "-Wl,--whole-archive" This adds executorch_prim::* to the build as the executorch_prim ops are added with a c++ static initialize that get optimized away by the linker as the variable in never used in the normal linking. See docs/source/runtime-build-and-cross-compilation.md
Tested on Arm backend using a non delegated view. Without this non of the executorch_prim:: can be found/used during runtime.