Skip to content

[ET-VK][ez] properly parse skip memory metadata pass #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[ET-VK][ez] properly parse skip memory metadata pass #6712

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9952ea2
[ET-VK][ez] properly parse skip memory metadata pass
SS-JIA Nov 7, 2024
69e96f2
Update on "[ET-VK][ez] properly parse skip memory metadata pass"
SS-JIA Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backends/vulkan/partitioner/vulkan_partitioner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,10 @@ def parse_compile_options(compile_options: Dict[str, Any]) -> List[CompileSpec]:
if isinstance(value, (VkStorageType, VkMemoryLayout)):
value_bytes = int(value).to_bytes(4, byteorder="little")
compile_specs.append(CompileSpec(key, value_bytes))

if isinstance(value, bool):
value_bytes = value.to_bytes(1, byteorder="little")
compile_specs.append(CompileSpec(key, value_bytes))

if key == "texture_limits":
compile_specs.append(
Expand Down
4 changes: 4 additions & 0 deletions backends/vulkan/vulkan_preprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ def parse_compile_spec(compile_specs: List[CompileSpec]) -> Dict[str, Any]:
)
if spec.key in {"texture_limits_x", "texture_limits_y", "texture_limits_z"}:
options[spec.key] = int.from_bytes(spec.value, byteorder="little")

if spec.key == "skip_tag_memory_metadata":
options[spec.key] = bool.from_bytes(spec.value, byteorder="little")

# Unhandled options are ignored

return options
Expand Down
Loading