Add support for uint16 in quant and dequant kernels #6724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In preparation for using uint16 on Cadence, add support to the quant kernels. We use the "Bits16" type for this purpose. This is an uninterpreted dtype that only works for a subset of kernels. We plan to only support it as a quant and dequant target. Reviewed By: hsharma35, mcremon-meta Differential Revision: D65370235
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6724
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c13cfae with merge base 39e5b91 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65370235 |
mcremon-meta
approved these changes
Nov 8, 2024
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Nov 15, 2024
Summary: In preparation for using uint16 on Cadence, add support to the quant kernels. Same as: pytorch#6724, but added UInt16 as well as Bits16. Differential Revision: D66016288
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Nov 15, 2024
Summary: In preparation for using uint16 on Cadence, add support to the quant kernels. Same as: pytorch#6724, but added UInt16 as well as Bits16. Differential Revision: D66016288
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Nov 15, 2024
Summary: In preparation for using uint16 on Cadence, add support to the quant kernels. Same as: pytorch#6724, but added UInt16 as well as Bits16. Reviewed By: JacobSzwejbka, zonglinpeng Differential Revision: D66016288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In preparation for using uint16 on Cadence, add support to the quant kernels.
We use the "Bits16" type for this purpose. This is an uninterpreted dtype that
only works for a subset of kernels. We plan to only support it as a quant
and dequant target.
Reviewed By: hsharma35, mcremon-meta
Differential Revision: D65370235