Skip to content

Correctly set _GLIBCXX_USE_CXX11_ABI pybind compile options #6744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2024
Merged

Correctly set _GLIBCXX_USE_CXX11_ABI pybind compile options #6744

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2451027
Update torchao pinned commit to latest
huydhn Nov 7, 2024
de0311c
Correctly set _GLIBCXX_USE_CXX11_ABI pybind compile options
huydhn Nov 9, 2024
521ded9
Remove unwanted change
huydhn Nov 9, 2024
7dea5c0
Update CMakeLists.txt
huydhn Nov 9, 2024
51d6fba
Update CMakeLists.txt to remove the empty else branch
huydhn Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,15 +716,27 @@ if(EXECUTORCH_BUILD_PYBIND)
endif()

# compile options for pybind
set(_pybind_compile_options
-Wno-deprecated-declarations
-fPIC
-frtti
-fexceptions
# libtorch is built with the old ABI, so we need to do the same for any
# .cpp files that include torch, c10, or ATen targets.
-D_GLIBCXX_USE_CXX11_ABI=0
)
if(EXECUTORCH_DO_NOT_USE_CXX11_ABI)
set(_pybind_compile_options
-Wno-deprecated-declarations
-fPIC
-frtti
-fexceptions
# libtorch is built with the old ABI, so we need to do the same for any
# .cpp files that include torch, c10, or ATen targets. Note that PyTorch
# nightly binary is built with _GLIBCXX_USE_CXX11_ABI set to 0 while its
# CI build sets this to 1 (default)
-D_GLIBCXX_USE_CXX11_ABI=0
)
else()
set(_pybind_compile_options
-Wno-deprecated-declarations
-fPIC
-frtti
-fexceptions
)
endif()

# util lib
add_library(
util ${CMAKE_CURRENT_SOURCE_DIR}/extension/evalue_util/print_evalue.cpp
Expand Down
Loading