Skip to content

[ET] Fix serde handling of inf #6799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[ET] Fix serde handling of inf #6799

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dce3039
[ET] Fix serde handling of `inf`
SS-JIA Nov 12, 2024
e176763
Update on "[ET] Fix serde handling of `inf`"
SS-JIA Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion exir/serde/export_serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import math
import operator
import re
import sys
import typing

from contextlib import contextmanager
Expand Down Expand Up @@ -1847,7 +1848,13 @@ def deserialize(
self.symbol_name_to_range = {}
if symbol_name_to_range:
for k, vr in symbol_name_to_range.items():
lower = int(vr.lower)
if math.isinf(vr.lower) and vr.lower < 0:
lower = -math.inf
elif math.isinf(vr.lower):
lower = math.inf
else:
lower = int(vr.lower)

if vr.upper >= 2: # max is >= 2, not sym bool range
lower = max(2, lower)
self.symbol_name_to_range[k] = symbolic_shapes.ValueRanges(
Expand Down
Loading