Improve ET_ASSERT_UNREACHABLE_MSG to use formatting #6802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6802
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit ce43948 with merge base ecdc007 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65693396 |
dbort
approved these changes
Nov 12, 2024
Contributor
dbort
left a comment
dbort
left a comment
There was a problem hiding this comment.
Please fix the lint job before landing
dulinriley
force-pushed
the
export-D65693396
branch
from
8e56894 to
aebdb6d
Compare
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Nov 13, 2024
Summary: The macro `ET_ASSERT_UNREACHABLE_MSG` didn't allow for format strings unlike the other `ET_CHECK` macros. Add this capability and fix any users of it. Reviewed By: dbort Differential Revision: D65693396
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65693396 |
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
Nov 13, 2024
Summary: The macro `ET_ASSERT_UNREACHABLE_MSG` didn't allow for format strings unlike the other `ET_CHECK` macros. Add this capability and fix any users of it. Reviewed By: dbort Differential Revision: D65693396
dulinriley
force-pushed
the
export-D65693396
branch
from
aebdb6d to
6ab1086
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65693396 |
Summary: The macro `ET_ASSERT_UNREACHABLE_MSG` didn't allow for format strings unlike the other `ET_CHECK` macros. Add this capability and fix any users of it. Reviewed By: dbort Differential Revision: D65693396
dulinriley
force-pushed
the
export-D65693396
branch
from
6ab1086 to
ce43948
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65693396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The macro
ET_ASSERT_UNREACHABLE_MSGdidn't allow for formatstrings unlike the other
ET_CHECKmacros.Add this capability and fix any users of it.
Reviewed By: dbort
Differential Revision: D65693396