-
Notifications
You must be signed in to change notification settings - Fork 709
Use linux.4xlarge.memory instead of linux.12xlarge #6896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6896
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 8204737 with merge base ec68eb3 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huydhn Before merging can you link the comparison of job execution time between using linux.4xlarge.memory and linux.12xlarge? Would like to understand the actual trade-off we made, ideally we should expect it to be tiny
| "resnet50": "linux.12xlarge", | ||
| "llava": "linux.12xlarge", | ||
| "llama3_2_vision_encoder": "linux.12xlarge", | ||
| # "llama3_2_text_decoder": "linux.12xlarge", # TODO: re-enable test when Huy's change is in / model gets smaller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you attach the job link to this model since we re-enable it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I think I will comment it out and leave it for latter. It doesn't OOM but take forever to export (close to 6 hours so far). I don't have much context, so probably need help from @dvorjackz to figure this one out
linux.4xlarge.memoryhas 128 GB of memory with 16 CPU cores whilelinux.12xlarge, a more expensive runner, has only 96 GB of memory on a whopping 48 CPU cores.Testing
Example runs for:
dl3https://github.com/pytorch/executorch/actions/runs/11863238941/job/33064335597?pr=6896 (20m vs 19m in trunk)emformer_predicthttps://github.com/pytorch/executorch/actions/runs/11863238941/job/33064336524?pr=6896 (1h30m vs 1h20m in trunk)