Skip to content

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Nov 15, 2024

Stack from ghstack (oldest at bottom):

  • (to be filled)

Context

Recently, we switched to using VK_IMAGE_TILING_LINEAR to minimize memory footprint.

However, according to the Vulkan Spec the VK_IMAGE_TILING_LINEAR tiling may only be available for 2D textures.

Changes

  • When constructing the Adapter class, check if it's possible to create a 3D texture with LINEAR tiling
  • Add a way to query preferred tiling from Context
  • Construct VkImage with the preferred tiling.

Differential Revision: D66029137

## Context

Recently, we switched to using `VK_IMAGE_TILING_LINEAR` to minimize memory footprint.

However, according to the [Vulkan Spec](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkImageCreateInfo.html) the `VK_IMAGE_TILING_LINEAR` tiling may only be available for 2D textures.

## Changes

* When constructing the `Adapter` class, check if it's possible to create a 3D texture with LINEAR tiling
* Add a way to query preferred tiling from `Context`
* Construct VkImage with the preferred tiling.

Differential Revision: [D66029137](https://our.internmc.facebook.com/intern/diff/D66029137/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6900

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 93ee6c1 with merge base 54899fe (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2024
@SS-JIA SS-JIA closed this Nov 19, 2024
@SS-JIA SS-JIA deleted the gh/SS-JIA/151/head branch January 24, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants