Skip to content

Conversation

@navsud
Copy link
Contributor

@navsud navsud commented Nov 18, 2024

Summary:

  • Replace inf (-inf) to 64k (-64k) as we use int16 for activations.
  • For int16 activations, "MinMaxObserver" is recommended, updated quantizer to reflect this change.

Repro command:
python -m executorch.examples.models.llama.export_llama --disable_dynamic_shape --qnn --pt2e_quantize qnn_16a4w -v -kv -p ~/pllm/stories110M/params.json -c ~/pllm/stories110M/stories_110M.pt --soc_model SM8650 -n ~/pllm/stories110M/exported_models/sm8650.pte --max_seq_len 512 --tokenizer_path ~/pllm/stories110M/tokenizer.model 2>&1 | tee ~/pllm/stories110M/exported_models/export_log.txt

Differential Revision: D66037630

Summary:
- Replace inf (-inf) to 64k (-64k) as we use int16 for activations.
- For int16 activations, "MinMaxObserver" is recommended, updated quantizer to reflect this change.

Differential Revision: D66037630
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6939

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit ad5c992 with merge base a0ac820 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66037630

@navsud navsud marked this pull request as draft November 18, 2024 22:57
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 29, 2025
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants