Skip to content

Update JNI binding layer comments to indicate that forward/execute is not thread-safe #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GregoryComer wants to merge 1 commit into from
Closed

Update JNI binding layer comments to indicate that forward/execute is not thread-safe #6947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions extension/android/src/main/java/org/pytorch/executorch/Module.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,19 @@ public static Module load(final String modelPath) {
/**
* Runs the 'forward' method of this module with the specified arguments.
*
* @param inputs arguments for the ExecuTorch module's 'forward' method. Note: if method 'forward'
* requires inputs but no inputs are given, the function will not error out, but run 'forward'
* with sample inputs.
* @param inputs arguments for the ExecuTorch module's 'forward' method. This function is not
* thread safe and must not be called while a previous inference is in progress. Additionally,
* if method 'forward' requires inputs but no inputs are given, the function will not error
* out, but run 'forward' with sample inputs.
* @return return value from the 'forward' method.
*/
public EValue[] forward(EValue... inputs) {
return mNativePeer.forward(inputs);
}

/**
* Runs the specified method of this module with the specified arguments.
* Runs the specified method of this module with the specified arguments. This function is not
* thread safe and must not be called while a previous inference is in progress.
*
* @param methodName name of the ExecuTorch method to run.
* @param inputs arguments that will be passed to ExecuTorch method.
Expand Down
Loading