[ET-VK] Only save_cache the first time #6966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6966
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 47b1932 with merge base 711f1c2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
junpi3
pushed a commit
that referenced
this pull request
Nov 19, 2024
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) ghstack-source-id: 254381356 Pull Request resolved: #6966
|
This pull request was exported from Phabricator. Differential Revision: D66179919 |
SS-JIA
approved these changes
Nov 19, 2024
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) [ghstack-poisoned]
junpi3
pushed a commit
that referenced
this pull request
Nov 19, 2024
Pull Request resolved: #6966 Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. ghstack-source-id: 254410706 @exported-using-ghexport Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/)
|
This pull request was exported from Phabricator. Differential Revision: D66179919 |
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66179919 |
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66179919 |
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66179919 |
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66179919 |
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66179919 |
facebook-github-bot
merged commit 775b361
into
gh/jorgep31415/125/base
42 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Nov 21, 2024
Pull Request resolved: #6966 Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. ghstack-source-id: 254701486 @exported-using-ghexport Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) --------- Co-authored-by: jorgep31415 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
save_cachefrom Runtime dtor to model destroy #6974Runtimemove #6964Add a check in
save_cacheto return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time.Differential Revision: D66179919