Skip to content

[ET-VK] Remove unneeded Runtime move #7000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[ET-VK] Remove unneeded Runtime move #7000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions backends/vulkan/runtime/vk_api/Runtime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ std::unique_ptr<Runtime> init_global_vulkan_runtime() {
};

try {
return std::make_unique<Runtime>(Runtime(default_config));
return std::make_unique<Runtime>(default_config);
} catch (...) {
}

Expand Down Expand Up @@ -323,16 +323,6 @@ Runtime::~Runtime() {
instance_ = VK_NULL_HANDLE;
}

Runtime::Runtime(Runtime&& other) noexcept
: config_(other.config_),
instance_(other.instance_),
adapters_(std::move(other.adapters_)),
default_adapter_i_(other.default_adapter_i_),
debug_report_callback_(other.debug_report_callback_) {
other.instance_ = VK_NULL_HANDLE;
other.debug_report_callback_ = {};
}

uint32_t Runtime::create_adapter(const Selector& selector) {
VK_CHECK_COND(
!device_mappings_.empty(),
Expand Down
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/vk_api/Runtime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class Runtime final {
Runtime(const Runtime&) = delete;
Runtime& operator=(const Runtime&) = delete;

Runtime(Runtime&&) noexcept;
Runtime(Runtime&&) = delete;
Runtime& operator=(Runtime&&) = delete;

~Runtime();
Expand Down
Loading