Add aot_arm_compiler flag to allow the reordering of the inputs #7005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add capability to use cmd input order in the backend * Extend the test infrastructure to handle this
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7005
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit a863305 with merge base 43555d2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Collaborator
Author
|
@pytorchbot label 'partner: arm' |
pytorch-bot
bot
added
the
partner: arm
Collaborator
|
@pytorchbot label "topic: not user facing" |
freddan80
approved these changes
Nov 25, 2024
swolchok
reviewed
Nov 25, 2024
| def vela_bin_pack_io(prefix, data, shape_order=None): | ||
| vela_input_shapes = data[prefix + "_shape"] | ||
|
|
||
| order = shape_order if shape_order else range(len(vela_input_shapes)) |
Contributor
There was a problem hiding this comment.
nit: order = shape_order or range(len(vela_input_shapes)) would be more idiomatic
Collaborator
Author
There was a problem hiding this comment.
Thank you for the review, and I agree.
I will fix this in another commit.
Thanks,
Saoirse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a argument to aot_arm_compiler to allow for the ordering of the inputs.